On 30 January 2015 at 13:45, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2015-01-30 at 13:31 +0100, Michal Kazior wrote: > >> + INIT_LIST_HEAD(&ar->arctxs); >> INIT_LIST_HEAD(&ar->arvifs); > > I'm not sure why you have an interface list, but I'd say you don't need > either since you have enumeration APIs: > > ieee80211_iterate_active_interfaces[_atomic,...] > > and > > ieee80211_iter_chan_contexts_atomic > > :) I recall that at least there's one case where using these helpers is impossible: drv_config() which can be called while mac80211 is already holding iflist_mtx. ath10k needs to iterate over vifs and issue blocking commands sometimes so it can't use atomic/rcu versions either. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
