On Fri, Jan 23, 2015 at 12:45 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > These conditions are rather difficult to follow, for example > because "!sta" only exists to not crash in the case that we > don't have a station pointer (WLAN_TDLS_SETUP_REQUEST) in > which the additional condition (peer supports HT) doesn't > actually matter anyway. > > Cleaning this up only duplicates two lines of code but makes > the rest far easier to read, so do that. > > As a side effect, smatch stops complaining about the lack of > a sta pointer test after the !sta (since the !sta goes away) > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> Reviewed-by: Arik Nemtsov <arik@xxxxxxxxxx> Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
