On Tue, Jan 20, 2015 at 2:35 PM, Janusz Dziedzic
<janusz.dziedzic@xxxxxxxxx> wrote:
> Add VHT80/VHT160 support for IBSS.
> Drivers could activate this feature by
> setting NL80211_FEATURE_VHT_IBSS flag.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx>
[...]
> +u8 *ieee80211_ie_build_vht_oper(u8 *pos, struct ieee80211_sta_vht_cap *vht_cap,
> + const struct cfg80211_chan_def *chandef)
> +{
> + struct ieee80211_vht_operation *vht_oper;
> +
> + /* Build VHT Operation */
> + *pos++ = WLAN_EID_VHT_OPERATION;
> + *pos++ = sizeof(struct ieee80211_vht_operation);
> +
> + vht_oper = (struct ieee80211_vht_operation *)pos;
> +
> + vht_oper->center_freq_seg1_idx =
> + ieee80211_frequency_to_channel(chandef->center_freq1);
> + vht_oper->center_freq_seg2_idx = 0;
> + vht_oper->basic_mcs_set = vht_cap->vht_mcs.rx_mcs_map;
> +
> + switch (chandef->width) {
> + case NL80211_CHAN_WIDTH_80:
> + vht_oper->chan_width = IEEE80211_VHT_CHANWIDTH_80MHZ;
> + break;
> + case NL80211_CHAN_WIDTH_80P80:
> + vht_oper->chan_width = IEEE80211_VHT_CHANWIDTH_80P80MHZ;
> + vht_oper->center_freq_seg2_idx =
> + ieee80211_frequency_to_channel(chandef->center_freq2);
> + break;
> + case NL80211_CHAN_WIDTH_160:
> + vht_oper->chan_width = IEEE80211_VHT_CHANWIDTH_160MHZ;
> + break;
> + default:
> + return pos;
> + }
Shouldn't you also set vht_oper->basic_mcs_set here? Of course if you
have no use for it in IBSS I can add it later.
Some peers (notably mac80211-based ones) might not use the info, but
others might..
Arik
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
