On Friday, January 23, 2015 01:27:05 PM Nicholas Mc Guire wrote: > On Thu, 22 Jan 2015, Christian Lamparter wrote: > > On Tuesday, January 20, 2015 06:25:43 AM Nicholas Mc Guire wrote: > > > @@ -249,9 +250,11 @@ int p54_download_eeprom(struct p54_common *priv, void *buf, > > > + wiphy_err(priv->hw->wiphy, > > > + "device does not respond or signal received!\n"); > > Tried fixing this up - but simply no clue what coding style > rule that might have violated - and my attempts to fix this > did not succeed - allignment seems righta - the complete siequence is: > > timeout = wait_for_completion_interruptible_timeout( > &priv->eeprom_comp, HZ); > if (timeout <= 0) { > wiphy_err(priv->hw->wiphy, > "device does not respond or signal received!\n"); > ret = -EBUSY; > } > > what am I overlooking ? Not much, you might be confused simply because your editor and email program doesn't use a fixed space font (or it is not enabled (yet)). Fixing this is just a matter of adding a few extra spaces so the text lines up with the open parenthesis. original: + wiphy_err(priv->hw->wiphy, + "device does not respond or signal received!\n"); aligned: + wiphy_err(priv->hw->wiphy, + "device does not respond or signal received!\n"); Regards, Christian -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html