On Thu, 22 Jan 2015, Christian Lamparter wrote:
> On Tuesday, January 20, 2015 06:25:43 AM Nicholas Mc Guire wrote:
> > if(!wait_for_completion_interruptible_timeout(...))
> > only handles the timeout case - this patch adds handling the
> > signal case the same as timeout.
> >
> > Signed-off-by: Nicholas Mc Guire <der.herr@xxxxxxx>
> Acked-by: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx>
>
> > diff --git a/drivers/net/wireless/p54/fwio.c b/drivers/net/wireless/p54/fwio.c
> > index bc065e8..5367d51 100644
> > --- a/drivers/net/wireless/p54/fwio.c
> > +++ b/drivers/net/wireless/p54/fwio.c
> > @@ -249,9 +250,11 @@ int p54_download_eeprom(struct p54_common *priv, void *buf,
> >
> > p54_tx(priv, skb);
> >
> > - if (!wait_for_completion_interruptible_timeout(
> > - &priv->eeprom_comp, HZ)) {
> > - wiphy_err(priv->hw->wiphy, "device does not respond!\n");
> > + timeout = wait_for_completion_interruptible_timeout(
> > + &priv->eeprom_comp, HZ);
> > + if (timeout <= 0) {
> > + wiphy_err(priv->hw->wiphy,
> > + "device does not respond or signal received!\n");
> > ret = -EBUSY;
> > }
> > priv->eeprom = NULL;
> >
>
> CHECK: Alignment should match open parenthesis
> #98: FILE: drivers/net/wireless/p54/fwio.c:257:
> + wiphy_err(priv->hw->wiphy,
> + "device does not respond or signal received!\n");
>
> total: 0 errors, 0 warnings, 1 checks, 21 lines checked
>
Tried fixing this up - but simply no clue what coding style
rule that might have violated - and my attempts to fix this
did not succeed - allignment seems righta - the complete siequence is:
timeout = wait_for_completion_interruptible_timeout(
&priv->eeprom_comp, HZ);
if (timeout <= 0) {
wiphy_err(priv->hw->wiphy,
"device does not respond or signal received!\n");
ret = -EBUSY;
}
what am I overlooking ?
thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
