On 01/07/15 23:16, Johannes Berg wrote:
On Wed, 2015-01-07 at 20:18 +0100, Giel van Schijndel wrote:
IMO the aligned block of code has the significant advantage of taking
advantage of humans' ability to spot things that break a pattern. Which
in this case becomes *very* visible when properly aligned, because
without the alignment there is no (visual) pattern (or at least not one
very suitable for my "visual processing system", I know the same applies
to at least some others).
Yeah, well, but why even invoke that "visual processing system"?
If you look, for example, at the __skb_clone function it just uses a
macro:
#define C(x) n->x = skb->x
This requires fixed names so I generally prefer to add them:
#define C(d, s, f) (d)->f = (s)->f
and then
C(len);
C(data_len);
C(acx, conf, window_size);
C(acx, conf, increase_time);
Regards,
Arend
etc.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
