On Mon, Jan 05, 2015 at 10:54:31 +0100, Johannes Berg wrote: > On Sun, 2015-01-04 at 19:00 +0100, Giel van Schijndel wrote: >> --- >> drivers/net/wireless/ti/wlcore/acx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c >> index beb354c..93a2fa8 100644 >> --- a/drivers/net/wireless/ti/wlcore/acx.c >> +++ b/drivers/net/wireless/ti/wlcore/acx.c >> @@ -1725,7 +1725,7 @@ int wl12xx_acx_config_hangover(struct wl1271 *wl) >> acx->decrease_delta = conf->decrease_delta; >> acx->quiet_time = conf->quiet_time; >> acx->increase_time = conf->increase_time; >> - acx->window_size = acx->window_size; >> + acx->window_size = conf->window_size; > > It would be far better to fix the bug *first*, that way the bugfix can > be cherry-picked/applied to trees that don't have the alignment. I agree on the ordering. As for: > (And anyway I question the value of the alignment - if you really want > to make this bug disappear you could perhaps use a macro) And: On Wed, Jan 07, 2015 at 20:40:57 +0200, Andy Shevchenko wrote: > On Sun, Jan 4, 2015 at 8:00 PM, Giel van Schijndel <me@xxxxxxxxx> wrote: > > This highlights the differences (errors). > > Seems like patch for the patch. Just fix an error like it's done here: > http://www.spinics.net/lists/linux-wireless/msg131667.html IMO the aligned block of code has the significant advantage of taking advantage of humans' ability to spot things that break a pattern. Which in this case becomes *very* visible when properly aligned, because without the alignment there is no (visual) pattern (or at least not one very suitable for my "visual processing system", I know the same applies to at least some others). -- Met vriendelijke groet, With kind regards, Giel van Schijndel
Attachment:
signature.asc
Description: Digital signature
