Hi Johannes, How about having a flag for offchannel CAC capability and check for netdev carrier state only when this capability is supported? Thanks, Avinash ________________________________________ From: Johannes Berg [johannes@xxxxxxxxxxxxxxxx] Sent: Tuesday, December 23, 2014 4:07 PM To: Avinash Patil Cc: janusz.dziedzic@xxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Amitkumar Karwar Subject: Re: [PATCH] cfg80211: do not check for carrier during start_radar_detect On Tue, 2014-12-23 at 11:36 +0100, Johannes Berg wrote: > On Tue, 2014-12-23 at 02:30 -0800, Avinash Patil wrote: > > Oops.. > > > > Are you talking about this? > > >>So, at least we should move if (netif_carrier_ok(dev)) check to mac80211 otherwise we might change channel of the running interface (via vif_use_channel). > > > > I can move this check to ieee80211_start_radar_detection but I dont have any hardware to test these modifications. > > That should be ok - however maybe you don't need those modifications at > all? > > Frankly I'm not even sure how off-channel CAC stuff would work but > Janusz probably knows what he's talking about :) Also - maybe we need some sort of capability flag for this, and then the check doesn't have to move but just be made conditional on not having the feature? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
