Hi Janusz, Any further update on this? Thanks, Avinash -----Original Message----- From: Janusz Dziedzic [mailto:janusz.dziedzic@xxxxxxxxx] Sent: 01 December 2014 12:44 To: Avinash Patil Cc: Johannes Berg; Simon Wunderlich; Amitkumar Karwar; linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; John W. Linville Subject: Re: [PATCH] cfg80211: do not check for carrier during start_radar_detect On 28 November 2014 at 17:35, Avinash Patil <patila@xxxxxxxxxxx> wrote: > Yes; beats me as well. > > That's why I added original authors - Simon and Janusz. > > -Avinash > > On Nov 28, 2014 8:41 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> >> On Fri, 2014-11-28 at 16:58 +0530, Avinash Patil wrote: >> > Radar detection happens before starting AP; so netdev carrier may >> > be dormant at this time. Remove this check from cfg80211_start_radar_detection. >> >> Looks fine to me, but I wonder how it ever worked? >> radar detection starts before we setup AP, so woks fine Seems this patch unlock off-channel CAC (we are connected/ap started and detect radar on other channel), but seem mac80211 don't support this correctly now. So, at least we should move if (netif_carrier_ok(dev)) check to mac80211 otherwise we might change channel of the running interface (via vif_use_channel). BR Janusz >> johannes >> >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
