Search Linux Wireless

Re: [PATCH] mac80211: fix dot11MulticastTransmittedFrameCount tested address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2014-12-21 at 15:25 +0200, Eliad Peller wrote:
> dot11MulticastTransmittedFrameCount should be updated according
> to the DA, which might be different from hdr1.
> 
> (Checking hdr1 results in the counter being 0 in case of station,
> as TODS data frames use hdr1 for the bssid address)

I've found this in the spec - see sta_tx_dcf_3.1d(10) (page 2410 of
802.11-2012):

cTmcfrm:=
  If (fsdu!grpa or
      ((toDs(tpdu) = 1) and (isGrp(addr3(tpdu))) and (fsdu!fTot=fsdu!
fCur+1))
     )
  then inc(cTmcfrm)
  else cTmcfrm fi

fsdu!grpa is true if RA is multicast, but the rest is clearly checking
the DA (and for fragmentation, which can happen in that case.)

So I believe this patch is correct and will apply it (with some commit
message fixes - should say A1 not hdr1)

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux