As for drv_wake_tx_queue and ieee80211_tx_dequeue - is it really necessary? There are ieee80211_tx_status and ieee80211_free_txskb already, which can be used to decide from mac80211 level when to dequeue packet. It could be used even in case of drivers that are not aware of new mechanism at all. We could compute difference between drv_tx and tx_status/free_txskb calls, therefore getting number of frames in HW. What could help us to keep queues short. I've already written some code. This http://pastebin.com/dSd1zWt7 is patch that implements counter of frames in hardware in the way described above. It was necessary to differentiate between free_txskb and free_txskb. Information about frames in HW is exported to debugfs. I thought I could submit it, but just now did I found this thread, so I hope that it's adequate place to propose that. I tested it on ath5k and brcmsmac. One more thing - why not to use local->pending for holding packets? There is tx_pending tasklet already. I'm not sure if I understand the idea of local->pending queues correctly, but it seems to be a bit incoherent to have both pending and proposed ieee80211_txq. (It's my first post on linux kernel mailing list. Please, let me know if I did something wrong.) Best regards. 2014-12-15 13:00 GMT+01:00 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>: > On Fri, 2014-12-12 at 15:28 +0100, Felix Fietkau wrote: > >> > Management (and maybe control) frames can have different priorities as >> > well, this is only used for something with TDLS now I think though. >> With my implementation, those would go through the normal tx codepath, >> bypassing the software tx queues. Can you think of anything else that >> would need per-AC vif queues? > > Not off the top of my head. I just didn't even quite understand that you > were still using the normal tx path > > johannes > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
