Hi No the rtw_hw_resume23a() is not used anywhere. I also do a check of all functions that are not used, but not in the drivers/staging, I suspected that these might be under development and used in the future. What do you want to do, who decides? Kind regards Rickard Strandqvist 2014-12-15 16:48 GMT+01:00 Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>: > Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: >> On Sun, Dec 14, 2014 at 11:39:14PM +0100, Rickard Strandqvist wrote: >>> There is otherwise a risk of a possible null pointer dereference. >>> >>> Was largely found by using a static code analysis program called cppcheck. >>> >>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> >>> --- >>> drivers/staging/rtl8723au/os_dep/usb_intf.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/staging/rtl8723au/os_dep/usb_intf.c >>> b/drivers/staging/rtl8723au/os_dep/usb_intf.c >>> index 865743e..71a6330 100644 >>> --- a/drivers/staging/rtl8723au/os_dep/usb_intf.c >>> +++ b/drivers/staging/rtl8723au/os_dep/usb_intf.c >>> @@ -351,10 +351,11 @@ error_exit: >>> int rtw_hw_resume23a(struct rtw_adapter *padapter) >> >> That's weird. Is this function even called? > > [jes@ultrasam jes.git]$ find drivers/staging/rtl8723au -name \*.[ch] |xargs grep rtw_hw_resume > drivers/staging/rtl8723au/include/osdep_intf.h:int rtw_hw_resume23a(struct rtw_adapter *padapter); > drivers/staging/rtl8723au/os_dep/usb_intf.c:int rtw_hw_resume23a(struct rtw_adapter *padapter) > drivers/staging/rtl8723au/os_dep/usb_intf.c: DBG_8723A("==> rtw_hw_resume23a\n"); > [jes@ultrasam jes.git]$ find drivers/staging/rtl8723au -name \*.[ch] |xargs grep rtw_hw_suspend > drivers/staging/rtl8723au/include/osdep_intf.h:int rtw_hw_suspend23a(struct rtw_adapter *padapter); > drivers/staging/rtl8723au/os_dep/usb_intf.c:int rtw_hw_suspend23a(struct rtw_adapter *padapter) > drivers/staging/rtl8723au/os_dep/usb_intf.c: DBG_8723A("==> rtw_hw_suspend23a\n"); > > A more useful patch would be one removing those two functions IMHO. > > Jes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html