On 29 November 2014 at 09:56, Michael Büsch <m@xxxxxxx> wrote: > On Fri, 28 Nov 2014 22:32:30 -0500 > nick <xerofoify@xxxxxxxxx> wrote: > >> I don't have hardware for this driver on me, so I didn't test it. However this seems to >> be correct from my reading of the code around this function and other locking related >> to this driver. > > From the current docs: > >> * @set_tim: Set TIM bit. mac80211 calls this function when a TIM bit >> * must be set or cleared for a given STA. Must be atomic. > > So it is not allowed to lock a mutex here. Nicholas please be more careful with your patches. It seems your patch is wrong, you didn't check the docs and you didn't even say in the first place that it wasn't tested. You could at least submit with with RFT tag or sth. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
