On 2014-11-24 11:53, Kalle Valo wrote: > Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> writes: > >>> @@ -2537,6 +2560,17 @@ static int __ath10k_set_antenna(struct ath10k *ar, u32 tx_ant, u32 rx_ant) >>> ar->cfg_tx_chainmask = tx_ant; >>> ar->cfg_rx_chainmask = rx_ant; >>> >>> + ht_cap = ath10k_get_ht_cap(ar, true); >>> + vht_cap = ath10k_create_vht_cap(ar, true); >>> + >>> + if (ar->phy_capability & WHAL_WLAN_11G_CAPABILITY) >>> + ar->mac.sbands[IEEE80211_BAND_2GHZ].ht_cap = ht_cap; >>> + >>> + if (ar->phy_capability & WHAL_WLAN_11A_CAPABILITY) { >>> + ar->mac.sbands[IEEE80211_BAND_5GHZ].ht_cap = ht_cap; >>> + ar->mac.sbands[IEEE80211_BAND_5GHZ].vht_cap = vht_cap; >>> + } >> >> So this modifies stryct wiphy::bands after we have called >> ieee80211_register_hw(). Is this something which both cfg80211 and >> mac80211 support? I didn't find the documentation mentioning anything >> about this so I got a bit worried. > > Johannes mentioned me that this is not supported so I am reluctant to > take these. Unless I'm missing something, of course. FWIW, ath9k has been doing the same for a long time now. Antenna settings can only be changed while the device is stopped, so it should be safe. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html