Hi Arend,
Thanks for your review,
Yes; current description may be confusing. I will send v2 with correct patch description.
Thanks,
Avinash
________________________________________
From: Arend van Spriel [arend@xxxxxxxxxxxx]
Sent: Tuesday, November 04, 2014 8:52 PM
To: Amitkumar Karwar
Cc: linville@xxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; Avinash Patil
Subject: Re: [PATCH 4/5] mwifiex: do not setup AMPDU/AMSDU with broadcast receiver
On 11/04/14 12:57, Amitkumar Karwar wrote:
> From: Avinash Patil<patila@xxxxxxxxxxx>
>
> It is observed that device sometimes sends BA setup requests for
> broadcast mac address.
> Its pointless to check for availablity of AMPDU/AMSDU streams
> for broadcast mac address. This patch adds this check.
Maybe you should rephrase this a little. The last sentence seems to say:
"This patch adds a pointless check".
Regards,
Arend
> Signed-off-by: Amitkumar Karwar<akarwar@xxxxxxxxxxx>
> Signed-off-by: Avinash Patil<patila@xxxxxxxxxxx>
> ---
> drivers/net/wireless/mwifiex/11n.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/wireless/mwifiex/11n.h b/drivers/net/wireless/mwifiex/11n.h
> index 2ee268b..f275675 100644
> --- a/drivers/net/wireless/mwifiex/11n.h
> +++ b/drivers/net/wireless/mwifiex/11n.h
> @@ -84,6 +84,8 @@ mwifiex_is_amsdu_in_ampdu_allowed(struct mwifiex_private *priv,
> {
> struct mwifiex_tx_ba_stream_tbl *tx_tbl;
>
> + if (is_broadcast_ether_addr(ptr->ra))
> + return false;
> tx_tbl = mwifiex_get_ba_tbl(priv, tid, ptr->ra);
> if (tx_tbl)
> return tx_tbl->amsdu;
> @@ -96,6 +98,8 @@ static inline u8
> mwifiex_is_ampdu_allowed(struct mwifiex_private *priv,
> struct mwifiex_ra_list_tbl *ptr, int tid)
> {
> + if (is_broadcast_ether_addr(ptr->ra))
> + return false;
> if (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_UAP) {
> return mwifiex_is_station_ampdu_allowed(priv, ptr, tid);
> } else {
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
