On Wed, Oct 29, 2014 at 04:05:44PM +0100, Johannes Berg wrote: > On Wed, 2014-10-29 at 19:39 +0530, Rajkumar Manoharan wrote: > > > + u32 hdr_len = ieee80211_hdrlen(hdr->frame_control); > > > + trace_ath10k_rx_hdr(ar, hdr, hdr_len); > > + trace_ath10k_rx_payload(ar, skb->data + hdr_len, skb->len - hdr_len); > > Another note, since you're taking my suggestion :-) > > It would be worth hiding that inside the tracepoint's assign function, > so instead of passing data/len here you'd pass the full skb, or the full > skb data/skb len, like this: > > ar, skb->data, skb->len > > to both tracers. Then inside the tracer you can do the hdrlen check, and > that way move the code into the tracing so it's not hit when tracing is > disabled. > Nice. Let me send v2. Thanks once again. -Rajkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
