Search Linux Wireless

Re: [PATCH] ath10k: handle ieee80211 header and payload tracing separately

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-10-29 at 19:39 +0530, Rajkumar Manoharan wrote:

> +	u32 hdr_len = ieee80211_hdrlen(hdr->frame_control);

> +	trace_ath10k_rx_hdr(ar, hdr, hdr_len);
> +	trace_ath10k_rx_payload(ar, skb->data + hdr_len, skb->len - hdr_len);

Another note, since you're taking my suggestion :-)

It would be worth hiding that inside the tracepoint's assign function,
so instead of passing data/len here you'd pass the full skb, or the full
skb data/skb len, like this:

ar, skb->data, skb->len

to both tracers. Then inside the tracer you can do the hdrlen check, and
that way move the code into the tracing so it's not hit when tracing is
disabled.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux