On Mon, 2014-10-20 at 15:49 -0700, greearb@xxxxxxxxxxxxxxx wrote: > + * @requested_name Request a particular name. missing colon, missing documentation that it can be NULL (for no request) also missing in the documentation is the name change of the function > if (unlikely(rdev->wiphy_idx < 0)) { > + /* TODO: Fix this someday. */ That doesn't belong into this patch :) > /* give it a proper name */ > - dev_set_name(&rdev->wiphy.dev, PHY_NAME "%d", rdev->wiphy_idx); > + if (requested_name && requested_name[0]) { > + struct cfg80211_registered_device *rdev2; > + int wiphy_idx, taken = -1, result, digits; > + > + /* Code below is from cfg80211_dev_rename */ can you refactor this then please? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html