On Tue, 2014-10-21 at 18:20 +0200, Fabian Frederick wrote: > Fix checkpatch warnings: > > WARNING: debugfs_remove(NULL) is safe this check is probably not required I'll apply this; however, I think that checkpatch is a just tool, and the commit message should reflect why you're changing the code. Presumably you're not doing it to make the tool happy, but to address an issue that the tool pointed out, so I think in most cases the commit message should state the former, not the latter. Note that in this particular case the NULL check check could be there to avoid a memory write (which can be significant depending on the context) so blindly doing what the tool suggested wouldn't always be a good idea. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
