On Thu, 2014-09-11 at 15:39 +0530, Sanjeev Sharma wrote: > on some architecture spin_is_locked() always return false in > uniprocessor configuration and therefore it would be advise > to replace with lockdep_assert_held(). > > Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@xxxxxxxxxx> > --- > Changes in v2: > - corrected the typo Now it compiles, but you got the logic wrong. > +++ b/drivers/net/wireless/zd1211rw/zd_mac.c > @@ -235,7 +235,7 @@ void zd_mac_clear(struct zd_mac *mac) > { > flush_workqueue(zd_workqueue); > zd_chip_clear(&mac->chip); > - ZD_ASSERT(!spin_is_locked(&mac->lock)); > + lockdep_assert_held(&mac->lock); > ZD_MEMCLEAR(mac, sizeof(struct zd_mac)); > } Look closely at this again. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html