> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -586,11 +586,15 @@ enum ieee80211_key_alg {
> * @IEEE80211_KEY_FLAG_GENERATE_MMIC: This flag should be set by
> * the driver for a TKIP key if it requires Michael MIC
> * generation in software.
> + * @IEEE80211_KEY_FLAG_TKIP_REQ_RX_P1_KEY: This flag should bet by
> + * the driver for a TKIP key if it requires phase 1 key generation
> + * in SW.
Please get rid of the flag and just use a condition like
if (ops->update_tkip_callback &&
key->conf.flags & UPLOADED_TO_HARDWARE)
I cannot imagine hardware that wants this callback for some keys but not
for others.
> + *
> + * In TKIP some HW need to be provided a phase 1 key, for RX decryption
> + * acceleration (i.e. iwlwifi). Those drivers should set
> + * IEEE80211_KEY_FLAG_TKIP_REQ_RX_P1_KEY.
> + * The update_tkip_key() call updates the driver with the new phase 1 key.
> + * This happens everytime the iv16 wraps around (every 65536 packets). The
> + * set_key() call will happen only once during a rekeying session, it will not
I would say "The set_key() call will still happen only once for each
key, ..."
> + * include a valid phase 1 key. The valid phase 1 key is provided by
> + * udpate_tkip_key only. The trigger that makes mac80211 call this handler is
typo: update_tkip_key
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
