Hi,
Thanks for your efforts!
> +enum ieee80211_tkip_key_type {
> + IEEE80211_TKIP_P1_KEY = 1<<0,
Please don't make them look like flags, not giving any explicit value at
all would be fine.
> /**
> + * ieee80211_get_tkip_rc4_key - get a phase 2 key for skb
> + *
> + * This function computes a phase 2 key for an skb. It computes
> + * a phase 1 key if needed (iv16 wraps around). This function is to
> + * be used by drivers which can do HW encryption but need to compute
> + * to phase 2 key in SW.
That documentation seems wrong given you can ask for key types.
Looks good otherwise.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
