Hello, On Wed, 27 Aug 2014, Johannes Berg wrote: > On Wed, 2014-08-27 at 13:23 +0300, Julian Anastasov wrote: > > > BTW, what kind of packets (protocol) we want to drop? UDP? > > All IP protocols, this comes either from the IPv4 RFC (1122) or from the > wireless issue which affects all protocols. I did a grep for inet_add_protocol, in case if we prefer to use per-protocol checks: Protocols that look ok to me: TCP, SCTP, DCCP ICMP: missing check in icmp_rcv UDP, UDPLITE: need check in __udp4_lib_rcv IGMP: uses only multicast address? PIM: not sure if __pim_rcv() needs check, before skb_tunnel_rx() changes pkt_type? More protocols are also registered with inet_add_protocol(), I don't see pkt_type checks there, mostly tunnels: - IPPROTO_GRE - IPPROTO_L2TP - IPPROTO_IPIP - IPPROTO_IPV6 (tunnel64_rcv) If going to use a global check I hope there are no protocols that require exception to this rule. Regards -- Julian Anastasov <ja@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
