Michal Kazior <michal.kazior@xxxxxxxxx> writes: > On 14 August 2014 10:40, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: >> Michal Kazior <michal.kazior@xxxxxxxxx> writes: >> >>> It doesn't make much sense to overwrite send_cb >>> and recv_cb callbacks over and over again whenever >>> transport starts. Just make sure to unmask copy >>> engine interrupts when starting. >>> >>> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> >> >> The patch looks, just a followup question for the future: >> >>> @@ -1674,7 +1639,9 @@ static int ath10k_pci_ce_init(struct ath10k *ar) >>> pipe_info->hif_ce_state = ar; >>> attr = &host_ce_config_wlan[pipe_num]; >>> >>> - ret = ath10k_ce_init_pipe(ar, pipe_num, attr); >>> + ret = ath10k_ce_init_pipe(ar, pipe_num, attr, >>> + ath10k_pci_ce_send_done, >>> + ath10k_pci_ce_recv_data); >> >> As we call ath10k_ce_init_pipe() only once and seem to have only one set >> of functions, why even bother bother with function pointers? What if we >> just call the functions directly? > > Yeah, we can remove this abstraction later. I don't there's anything > depending on it anymore. Good, again something for a rainy day :) I added it to the TODO list (which we should cleanup as well): http://wireless.kernel.org/en/users/Drivers/ath10k/todo -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
