On 19 August 2014 10:23, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote:
> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>
> Should help debug firmware crashes, and give users a way
> to provide some useful debug reports to firmware developers.
>
> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx>
> ---
[...]
> +/* Save the main firmware stack */
> +static void ath10k_pci_dump_stack(struct ath10k *ar,
> + struct ath10k_fw_crash_data *crash_data)
> +{
> + lockdep_assert_held(&ar->data_lock);
> +
> + BUILD_BUG_ON(ATH10K_FW_STACK_SIZE % 4);
> +
> + ath10k_pci_diag_read_hi(ar, crash_data->stack_buf,
> + hi_stack, ATH10K_FW_STACK_SIZE);
Current master tree performs an implicit byte swap so the stack read
from target will be in host endianess. IOW on big-endian host you'll
messed up data and there's no indication of endianess anymore.
Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
