greearb@xxxxxxxxxxxxxxx writes:
> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>
> Print error if device failed to recover.
>
> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index b2e7303..ced5eca 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -3905,8 +3905,10 @@ static void ath10k_restart_complete(struct ieee80211_hw *hw)
> /* If device failed to restart it will be in a different state, e.g.
> * ATH10K_STATE_WEDGED */
> if (ar->state == ATH10K_STATE_RESTARTED) {
> - ath10k_info("device successfully recovered\n");
> + ath10k_info("device successfully recovered (state RESTARTED to ON)\n");
> ar->state = ATH10K_STATE_ON;
Here I think state prints should be in debug level too.
> + } else {
> + ath10k_info("device failed to recover (state %d)\n", ar->state);
> }
And should this be ath10k_err() as it's an unrecoverable error?
Also I would prefer this kind of indentation:
if (ar->state != ATH10K_STATE_RESTARTED) {
ath10k_err("device failed to recover");
goto out;
}
ath10k_info("device successfully recovered\n");
ar->state = ATH10K_STATE_ON;
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
