Michal Kazior <michal.kazior@xxxxxxxxx> writes:
> It doesn't make sense to re-init irqs completely
> whenever transport is started/stopped. Do it just
> once upon probing/removing.
>
> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx>
[...]
> @@ -1905,22 +1915,10 @@ static int __ath10k_pci_hif_power_up(struct ath10k *ar, bool cold_reset)
> goto err;
> }
>
> - ret = ath10k_ce_disable_interrupts(ar);
> - if (ret) {
> - ath10k_err("failed to disable CE interrupts: %d\n", ret);
> - goto err_ce;
> - }
> -
> - ret = ath10k_pci_init_irq(ar);
> - if (ret) {
> - ath10k_err("failed to init irqs: %d\n", ret);
> - goto err_ce;
> - }
> -
> ret = ath10k_pci_request_early_irq(ar);
> if (ret) {
> ath10k_err("failed to request early irq: %d\n", ret);
> - goto err_deinit_irq;
> + goto err_ce;
> }
You add ath10k_pci_ce_init() to probe() and respective
ath10k_pci_ce_deinit() to remove(), and you remove
ath10k_pci_ce_deinit() from hif_power_down(). But why do you leave
ath10k_pci_ce_init() to hif_power_up()? Isn't that unnecessary as we
already do that in probe()?
> + ath10k_info("pci irq %s (num %d) irq_mode %d reset_mode %d\n",
> + ath10k_pci_get_irq_method(ar), ar_pci->num_msi_intrs,
> + ath10k_pci_irq_mode, ath10k_pci_reset_mode);
"pci irq %s interrupts %d irq_mode %d ..."
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
