On Wed, Mar 19, 2008 at 06:42:43PM +0200, Emmanuel Grumbach wrote: > I ran some tests with the following configuration of wpa_supplicant: > key_mgmt=NONE > group=WEP104 > wep_key0=123456789A123456789A12345A > wep_key1=123456789A123456789A12345B > wep_key2=123456789A123456789A12345C > wep_key3=123456789A123456789A12345D > wep_tx_keyidx=2 > From what I saw, the driver got ioctl SIOCSIWAUTH several times, once at the > very beginning (even before wpa_supplicant read its config file). The value > was 1, which means 1X in wext language. I think there may be some misunderstanding here on how SIOCSIWAUTH is used.. That call for setting IW_AUTH_WPA_ENABLED to 1 (WPA enabled), not to set key management (IW_AUTH_KEY_MGMT). > Then I got SIOCSIWENCODEEXT with the keys, right after that. > There were other SIOCSIWAUTH calls but after SIOCSIWENCODEEXT, they didn't > help much. Help with what? > From include/linux/wireless.h I saw that there are only two "legal" options: > > /* IW_AUTH_KEY_MGMT values (bit field) */ > #define IW_AUTH_KEY_MGMT_802_1X 1 > #define IW_AUTH_KEY_MGMT_PSK 2 > > which is a bit poor... I would need something like > #define IW_AUTH_KEY_MGMT_NONE 0 Well, there is not an explicit define for that, but zero is indeed used to indicate that none of the listed key management options are used.. > In any case, this configuration (SIWAUTH with value = 1) seems quite odd > since I am not running 1X, this value looks like a default value. That's not what happened here as far as I can tell.. When starting to associate, wpa_supplicant would end up setting IW_AUTH_KEY_MGMT to 0 in this particular case. > I would need to get configured with SIWAUTH value = 0, before > SIOCSIWENCODEEXT, this would mean for me that the key that will be sent in > the future are static keys. The concept of "static keys" is a bit misleading.. And use of IW_AUTH_KEY_MGMT to distinguish the key type does not sound like the best thing to do here. > The value 0 is chosen on purpose: iwconfig doesn't send any SIWAUTH ioctl > and configures static WEP key. I would like IW_AUTH_KEY_MGMT_NONE to be the > default in a zeroed struct. I don't follow this.. IW_AUTH_KEY_MGMT is set to zero if 802.1X or WPA is not used. > Jouni, do you aggree that a change is needed in wpa_supplicant / wext to > support WEP static key and allow mac80211 to differentiate between the > config I copy pasted before and WEP keys coming from an AP through 1X ? No, I don't see why something in wpa_supplicant or WEXT would need to be changed. If the goal is to figure out whether the key that is being configured is a broadcast/default/group key, the ext_flags field for SIOCSIWENCODEEXT is has IW_ENCODE_EXT_GROUP_KEY flag. If the key is a unicast/individual/key-mapping key, this flag is not set. In addition, the addr.sa_data value is set to ff:ff:ff:ff:ff:ff for broadcast/default/group keys and to a unicast address for unicast/individual/key-mapping keys. Calling the keys "static" or "dynamic" is just going to cause confusion.. It does not matter whether the keys are statically configured (e.g., IEEE 802.1X "dynamic keys" for broadcast could be configured "statically" to support non-IEEE 802.1X STAs). The main difference is in whether they are broadcast/default/group keys or individual/unicast/key-mapping keys. As far as I know, this is already distinguished in the current interface. If not, please let me know exact details on the case that does not have such information. The driver will just need to know which key to use in the corner case if someone were to configure broadcast/default/group key with key index 0 and a unicast/individual key (always key index 0 if one were to follow the standard) and both could match an incoming frame (the broadcast/default/group key would be used if the addr1 field is broadcast/multicast; otherwise, the unicast/individual/key-mapping key would be used). -- Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
