> > There is lots of trailing whitespace (use scripts/checkpatch.pl) > >> + if (local->hw.conf.channel->band == IEEE80211_BAND_2GHZ && >> + have_higher_than_11mbit) > > and that really needs to be indented differently. > Oops, sorry for that :( >> + /* IBSS uses different parameters for Beacon sending */ >> + qparam.cw_min++; >> + qparam.cw_min *= 2; >> + qparam.cw_min--; >> + local->ops->conf_tx(local_to_hw(local), >> + IEEE80211_TX_QUEUE_BEACON, &qparam); > > And shouldn't we do that only for IBSS? I'm in favour of removing it > completely, however, since the beacon queue is a way to construct > hardware, not do things in software... Good question; I've just moved this part of code out of ieee80211_sta_set_ssid as that is not the best place for it. I don't object to removing that code completely; seems that noone uses IEEE80211_TX_QUEUE_BEACON anyway. On the other hand, it can be a good hint for those implementing beaconing on hw where it has to be set explicitly.. Vlado
Attachment:
signature.asc
Description: OpenPGP digital signature
