On Tue, 2008-03-18 at 13:48 +0100, Vladimir Koutny wrote: > Default WMM params have to be set according to beacon/probe response > information prior to authentication (or IBSS start/join). This does > not affect the use of 'real' WMM params as reported by AP. > > Signed-off-by: Vladimir Koutny <vlado@xxxxxx> Looks ok, but > + There is lots of trailing whitespace (use scripts/checkpatch.pl) > + if (local->hw.conf.channel->band == IEEE80211_BAND_2GHZ && > + have_higher_than_11mbit) and that really needs to be indented differently. > + /* IBSS uses different parameters for Beacon sending */ > + qparam.cw_min++; > + qparam.cw_min *= 2; > + qparam.cw_min--; > + local->ops->conf_tx(local_to_hw(local), > + IEEE80211_TX_QUEUE_BEACON, &qparam); And shouldn't we do that only for IBSS? I'm in favour of removing it completely, however, since the beacon queue is a way to construct hardware, not do things in software... johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
