(Please do not top-post.) On Sunday 08 June 2014 22:47:31 Rickard Strandqvist wrote: > I found this error in some of the files. And after discussion with > Larry Finger and Peter Wu, it was decided that all files with this if > statement should change. > > But of course I should update the comment to something more suitable. Right, do not forget to use [PATCH v2] as prefix and adjust the subject too as this is no longer just "cleaning up a statement that always evaluates to false", but rather "fix [insert stuff here] mask" (for the 0xfc cases). The commit message must describe why the change is beneficial, see other commit messages for examples. Kind regards, Peter > 2014-06-08 22:35 GMT+02:00 David Rientjes <rientjes@xxxxxxxxxx>: > > On Sun, 8 Jun 2014, Rickard Strandqvist wrote: > > > >> I find a logical error in an if statement '(X & 0xfc) == 0x3' is always false > >> > > > > Where is the 0xfc that your converting? > > > >> After pointing this out, Larry Finger informed what would be the correct one. > >> '(X & 0x3) == 0x3' > >> > > > > This is already what it is, just say that you're replacing it with the > > constant. > > > >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> > >> --- > >> drivers/net/wireless/rtlwifi/rtl8723be/hw.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/wireless/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/rtlwifi/rtl8723be/hw.c > >> index 0fdf090..b61044f 100644 > >> --- a/drivers/net/wireless/rtlwifi/rtl8723be/hw.c > >> +++ b/drivers/net/wireless/rtlwifi/rtl8723be/hw.c > >> @@ -1197,7 +1197,7 @@ static int _rtl8723be_set_media_status(struct ieee80211_hw *hw, > >> } > >> rtl_write_byte(rtlpriv, (MSR), bt_msr); > >> rtlpriv->cfg->ops->led_control(hw, ledaction); > >> - if ((bt_msr & 0x03) == MSR_AP) > >> + if ((bt_msr & MSR_AP) == MSR_AP) > >> rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00); > >> else > >> rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66); -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
