On 22 May 2014 15:43, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2014-05-22 at 15:28 +0200, Michal Kazior wrote: >> Having csa counters part of beacon and probe_resp >> structures makes it easier to get rid of possible >> reaces between setting a beacon and updating >> reaces -_- grr >> counters on SMP systems by guaranteeing counters >> are always consistent against given beacon struct. > > This makes a lot of sense. > >> static int ieee80211_assign_beacon(struct ieee80211_sub_if_data *sdata, >> - struct cfg80211_beacon_data *params) >> + struct cfg80211_beacon_data *params, >> + const u16 *csa_counter_offset_beacon, >> + int n_csa_counter_offset_beacon, >> + const u16 *csa_counter_offset_presp, >> + int n_csa_counter_offset_presp, >> + u8 csa_count) > > But that seems overkill. Maybe those CSA-related arguments could be in > some new struct so you don't have to pass "..., NULL, 0, NULL, 0, 0"? I didn't want to invent a structure just to pass a bunch of arguments. Hmm.. maybe we can move counter offsets into cfg80211_beacon_data? This would apply to cfg80211_csa_settings as well. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
