On Wed, May 07, 2014 at 10:31:05AM +0800, Adam Lee wrote: > On Tue, May 06, 2014 at 02:08:37PM -0400, John W. Linville wrote: > > > > Standard practice is to assume MSI is available, and let the quirks > > > > in the PCI subsystem reject the request to enable MSI. > > > > > > > > Also other drivers have a 'disable_msi' module parameter why not follow > > > > their example. > > > > > > > > > > Because some submodule's MSI causes an regression, and other submodules > > > of rtlwifi are not fully tested under MSI, we need to disable it by > > > default(regression has higher priority) and have an 'enable_msi' module > > > parameter for some certain users. > > > > Couldn't it be called 'disable_msi' and default to 'on'? > > It could be, will send an v2 patchset, thanks. Sorry, just grep linux/driver, there is no convention of 'disable_msi' parameter, only 5 drivers uses that, but 15 drivers are using 'msi'... Please still apply v1, setting 'disable_msi' to 'on' and asking users to set it to 'off' is a little weird. John, please ask me to send v2 if you think the 'disable_msi' parameter is better. Thanks. -- Adam Lee -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
