On Tue, May 06, 2014 at 10:19:15AM +0800, Adam Lee wrote: > On Mon, May 05, 2014 at 03:40:37PM -0700, Stephen Hemminger wrote: > > On Mon, 05 May 2014 09:56:16 -0500 > > Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: > > > > > On 05/05/2014 03:33 AM, Adam Lee wrote: > > > > This makes MSI support a module parameter, for debugging and workaround > > > > convenience. > > > > > > > > Signed-off-by: Adam Lee <adam.lee@xxxxxxxxxxxxx> > > > > > > Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> (for all 3 patches) > > > > > > I would have made the default for the MSI option to be true, but that is a > > > matter of preference, and only experience would show which default leads to the > > > fewer failures. On my laptop, both rtl8188ee and rtl8723be work either way. I am > > > now working on a driver for the RTL8192EE that also can use MSI - that has only > > > been tested with the option on. > > > > > > Larry > > > > Standard practice is to assume MSI is available, and let the quirks > > in the PCI subsystem reject the request to enable MSI. > > > > Also other drivers have a 'disable_msi' module parameter why not follow > > their example. > > > > Because some submodule's MSI causes an regression, and other submodules > of rtlwifi are not fully tested under MSI, we need to disable it by > default(regression has higher priority) and have an 'enable_msi' module > parameter for some certain users. Couldn't it be called 'disable_msi' and default to 'on'? -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
