On 28 April 2014 17:47, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2014-04-28 at 17:46 +0200, Johannes Berg wrote: > >> > Shouldn't interface combinations be verified here? What if there was a >> > bandwidth upgrade (after a downgrade) but in the meantime a vif with a >> > to-be incompatible chandef was brought up? >> >> Yeah that seems like a potential issue. > > Hm, wait, isn't this addressed by this code in > ieee80211_vif_change_bandwidth(): > > ctx = container_of(conf, struct ieee80211_chanctx, conf); > if (!cfg80211_chandef_compatible(&conf->def, chandef)) { > ret = -EINVAL; > goto out; > } Yeah, you're right. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html