On Mon, 2014-04-28 at 10:57 +0200, Michal Kazior wrote:
> > +static int ieee80211_set_ap_channel(struct wiphy *wiphy,
> > + struct net_device *dev,
> > + struct cfg80211_chan_def *chandef)
> > +{
> > + struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
> > + int ret;
> > + u32 changed = 0;
> > +
>
> Shouldn't interface combinations be verified here? What if there was a
> bandwidth upgrade (after a downgrade) but in the meantime a vif with a
> to-be incompatible chandef was brought up?
Yeah that seems like a potential issue.
> I think the existing usage
> of ieee80211_vif_change_bandwidth() in ieee80211_config_bw() already
> suffers from this problem or am I missing something?
That sounds like you're arguing it should be fixed in a separate patch
to ieee80211_vif_change_bandwidth()? :)
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
