Yeoh Chun-Yeow <yeohchunyeow@xxxxxxxxx> writes: >>> + if (ar->fw_version_build == 636) { >> >> Checking for firmware version in ath10k is a big no. For a functinality >> change like this you should add a new feature flag to enum >> ath10k_fw_features (and I need to then recreate the firmware image). >> > Should we just use the ATH10K_FW_FEATURE_WMI_10X? That's a bit dangerous if in the future there's a new firmware which doesn't have ATH10K_FW_FEATURE_WMI_10X but still doesn't support stand alone monitor mode. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html