On 24 April 2014 10:14, Chun-Yeow Yeoh <yeohchunyeow@xxxxxxxxx> wrote:
> Firmware 999.999.0.636 does not allow stand alone monitor
> mode. This means that bridging the STA mode and put it into
> promiscuous mode will also cause the firmware to crash. Avoid
> this.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@xxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index e2c01dc..f640328 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -647,10 +647,15 @@ static int ath10k_monitor_vdev_delete(struct ath10k *ar)
>
> static int ath10k_monitor_start(struct ath10k *ar)
> {
> - int ret;
> + int ret = -1;
>
> lockdep_assert_held(&ar->conf_mutex);
>
> + if (ar->fw_version_build == 636) {
> + ath10k_warn("stand alone monitor mode is not supported\n");
> + return ret;
> + }
I think Monitor operation should be performed on a best effort basis.
This means monitor_start/stop should be attempted once number of
non-monitor vdevs changes.
We should probably introduce a ath10k_recalc_monitor() for that purpose.
Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
