On 8 April 2014 08:53, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: > Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> writes: > >> Michal Kazior <michal.kazior@xxxxxxxxx> writes: >> >>> It was possible to create/delete/start/stop >>> monitor vdev from a few places that were not >>> exclusively protected against each other. This >>> resulted in monitor vdev being stopped/removed by >>> one call origin while another one was expecting it >>> to continue running. >>> >>> For example if CAC was started and interface's >>> promiscuous mode was toggled monitor vdev was >>> removed from the driver meaning no radar would be >>> detected. In additional a warning would be printed >>> upon CAC completion complaining it tried to stop >>> non-running monitor vdev. >>> >>> The patch simplifies monitor code by removing >>> IEEE80211_HW_WANT_MONITOR_VIF (which wasn't really >>> ever needed) and improves state tracking. It also >>> unifies prints. >>> >>> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> >> >> Thanks, applied. > > Actually there were two checkpatch warnings which I had missed: > > drivers/net/wireless/ath/ath10k/mac.c:2587: WARNING: line over 80 characters > drivers/net/wireless/ath/ath10k/mac.c:2852: WARNING: line over 80 characters > > I amended it like this: > [...] Sorry for the trouble and thanks! Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html