Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes: > On 04/04/2014 11:14 PM, Kalle Valo wrote: >> Andrea Merello <andrea.merello@xxxxxxxxx> writes: >> >>> From: Larry Finger <Larry.Finger@xxxxxxxxxxxx> >>> >>> rtl8180 driver can handle also rtl8185 and rtl8187SE cards, >>> however in userspace tools (network manager) it still appares >>> as "rtl8180". >>> This might lead the user to think the wrong driver is in use. >>> >>> This patch changes module name to "rtl818Xpci" that should be >>> more explanatory. >>> >>> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> >>> Signed-off-by: Andrea Merello <andrea.merello@xxxxxxxxx> >> >> [...] >> >>> -obj-$(CONFIG_RTL8180) += rtl8180.o >>> +obj-$(CONFIG_RTL8180) += rtl818Xpci.o >> >> Aren't module names usually all lower case? > > I do not feel strongly about this, but when I viewed the driver name > in the KDE applet for NetworkManager, the lower-case x sort of got > lost, whereas the upper-case one stood out. That was the reason for > the way I wrote the patch the way I did. In a terminal, the lc value > looks OK. I think it's confusing to use upper case letter in middle of a module name. There's no way to remember that when you are typing it :) I checked the ubuntu kernel 3.2.0-60-generic I had installed in this machine. Out of 3311 kernel modules only 50 had upper case letters and none of them were in drivers/net. > Perhaps I should have made it rtl818x_pci. That would be much more user friendly and also consistent with other wireless drivers. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
