Search Linux Wireless

Re: [PATCH 1/4] rtl8180: change module name in rtl818Xpci

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/04/2014 11:14 PM, Kalle Valo wrote:
Andrea Merello <andrea.merello@xxxxxxxxx> writes:

From: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
however in userspace tools (network manager) it still appares
as "rtl8180".
This might lead the user to think the wrong driver is in use.

This patch changes module name to "rtl818Xpci" that should be
more explanatory.

Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
Signed-off-by: Andrea Merello <andrea.merello@xxxxxxxxx>

[...]

-obj-$(CONFIG_RTL8180)	+= rtl8180.o
+obj-$(CONFIG_RTL8180)	+= rtl818Xpci.o

Aren't module names usually all lower case?

I do not feel strongly about this, but when I viewed the driver name in the KDE applet for NetworkManager, the lower-case x sort of got lost, whereas the upper-case one stood out. That was the reason for the way I wrote the patch the way I did. In a terminal, the lc value looks OK. Perhaps I should have made it rtl818x_pci.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux