Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> writes: > On 24 March 2014 11:06, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: >> Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> writes: >> >>> Introduce rx_status htt template instead of >>> stack version. >>> >>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> >> >> Why? What's the benefit from doing this? >> > This is the must in case we would like to report rssi + rates correctly. > I describe this in 2/2 - maybe squash them? Nah, better to keep them separated. But in patch 1 please document why you are doing that, so that I (and others cherry picking ath10k patches) don't need to guess. For example, you can say "in preparation for foo" or something like that. > Currently during heavy traffic we could have: >> 10 packets with START_VALID - correct RSSI + rates >> 10 packets with END_VALID >> 10 packets with START_VALID - correct RSSI + rates >> 10 packets with END_VALID - > ... > > Because of that we have to store rssi + rates for case when END_VALID only. > In other case when using monitor we will see: > - 10 packets with correct rssi/rates > - 10 packets with rssi=-95/rate=6Mbps Ok, I understand now. Please document that in patch 2. And in the future, please double check that your commit logs answer the question "why?". That will save everyone's time :) -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
