> diff --git a/drivers/net/wireless/rsi/rsi_main.h b/drivers/net/wireless/rsi/rsi_main.h [] > +static inline void rsi_dbg(u32 zone, const char *fmt, ...) > +{ > + struct va_format vaf; > + va_list args; > + > + va_start(args, fmt); > + > + vaf.fmt = fmt; > + vaf.va = &args; > + > + if (zone & rsi_zone_enabled) > + pr_info("%pV", &vaf); > + va_end(args); > +} I believe debugging messages should be emitted at KERN_DEBUG. Also, it seems that every use uses "%s: ", __func__. I think it'd be better to remove all those uses from the calling sites and use: %pS:, __builtin_return_address(0) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html