On 03/11/2014 04:16 AM, Kalle Valo wrote: > Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> writes: > >>> I think we should agree on one of the two approaches: >>> >>> a) start with a verb: >>> >>> "failed to add peer %pM on vdev %i: %d" >>> "failed to initialize dfs pattern detector" >>> "timed out while waiting for scan completion" >>> >>> b) start with a noun: >>> >>> "peer %pM on vdev %i could not be added: %d" >>> "dfs pattern detector could not initialize" >>> "scan timed out" >>> >>> These are still mixed. >>> >>> We could probably also limit the set of verbs, e.g. replace "could >>> not" with "failed to" as it's practically the same thing (assuming we >>> pick (a)). >> >> That's true. I would vote for option (a). > > I didn't get any comments about Michal's proposal. Can I conclude from > this that (a) above is ok for everyone? I like (a), but I would also suggest giving user a clue as to the severity. Something starting with 'failed' or 'warning' is pretty obvious. A timeout is less so..ie, how much of a problem is the timeout? Thanks, Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
