Michal Kazior <michal.kazior@xxxxxxxxx> writes: > On 3 March 2014 16:43, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: >> Currently there are different styles used for warning messages, unify them to >> look similar. >> >> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> >> --- > > [...] > > This still seems inconsistent. Sure. What I did here was that I just capitalised them messages and made sure that return code is printed in format ": %d\n". > I also don't like the capital letters (even for abbreviations) in > these kind of messages, but that's just my OCD.. I'm fine with starting a lower case letter. For me most important is that the messages follow the same style. > I think we should agree on one of the two approaches: > > a) start with a verb: > > "failed to add peer %pM on vdev %i: %d" > "failed to initialize dfs pattern detector" > "timed out while waiting for scan completion" > > b) start with a noun: > > "peer %pM on vdev %i could not be added: %d" > "dfs pattern detector could not initialize" > "scan timed out" > > These are still mixed. > > We could probably also limit the set of verbs, e.g. replace "could > not" with "failed to" as it's practically the same thing (assuming we > pick (a)). That's true. I would vote for option (a). > But then again, feel free to ignore my OCD :-) Hehe, I had to even google that :) -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
