Hi Johannes, > On Sun, 2014-02-23 at 15:08 +0100, Thomas Huehn wrote: >> Flag IEEE80211_TX_CTL_MORE_FRAMES is only used within the tx path while >> ieee80211_tx_info->control is valid. Therefore this patch moves this flag >> from info->flags structure into the info->control.flags and renames it to >> IEEE80211_TX_CTRL_FIRST_FRAGMENT. Define new IEEE80211_TX_TEMPORARY_CTRL_FLAGS >> to clear all temporary flags that are shifted to info->control.flags. > > Similar to before... this can't be right, you have to assume > info->control.flags is cleared when you get status data, which is in > fact a problem in the first patch already, but here the clearing of > „temporary" flags is quite wrong. ok… will send v2 > At least temporary flags don't suffer from the 'getting lost' problem as > in the first patch. > > I'll also note that this flag is treated wrongly in software retry > scenarios anyway, but it won’t really matter I guess. Do you mean the case when fragments after the first one get retransmitted by software ? Greetings Thomas-- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
