Search Linux Wireless

Re: [PATCH] cfg80211: regulatory, introduce NL80211_RRF_AUTO_BW rule flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2014-02-21 at 09:23 +0100, Janusz Dziedzic wrote:

> # must match <linux/nl80211.h> enum nl80211_reg_rule_flags

Well, it already doesn't:

> flag_definitions = {
>     'NO-OFDM': 1<<0,
>     'NO-CCK': 1<<1,
>     'NO-INDOOR': 1<<2,
>     'NO-OUTDOOR': 1<<3,
>     'DFS': 1<<4,
>     'PTP-ONLY': 1<<5,
>     'PTMP-ONLY': 1<<6,

Those are fine, and have been like this forever.

>     'NO-IR':        1<<7,
>     # hole at bit 8

These used to be PASSIVE-SCAN and NO-IBSS, but bit 8 is still reserved
in the kernel.

>     # hole at bit 9. FIXME: Where is NO-HT40 defined?
>     'NO-HT40': 1<<10,

Neither bit 9 nor bit 10 were ever used by the kernel.

Did old userspace create them?

> Which definition is correct now? Should I remove bit9 and bit10 from
> wireless-regdb or skip them in nl80211.h?

Since it's safer to not even have to worry about it, I'll change your
patch to use bit 11.

However, Luis, please sort out this situation, and if bits 9/10 were
ever used by userspace (they were never used by the kernel!) then please
submit a kernel patch that marks them as reserved in nl80211.h. The
kernel header file should be the master file defining the API, not some
"random" userspace tool.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux