On Wed, 2014-02-19 at 13:28 +0100, Stanislaw Gruszka wrote: > Similar change as on current patch "mac80211: fix calling > ieee80211_free_txskb with NULL skb", but for multicast queue. Patch does > not prevent crash, as dev_kfree_skb() checks against NULL skb, but it > help to prevent not necessary frame drop, when bc_buf queue was > partially flushed and no longer exceeds AP_MAX_BC_BUFFER . I don't think this makes sense. It doesn't really change anything, holding a spinlock isn't something magic that makes other things go away, so instead of * check queue length, is >= limit * free frame from queue, even if somebody else is dequeuing as well as before, you'd just have * check queue length, is >= limit * take lock * check queue length, is >= limit * drop frame * unlock * somebody else who was dequeuing now wakes up from waiting on the lock and finds no frame there It ultimately makes no difference at all, it just makes this code more difficult to read and understand. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
