Dear Johannes; Thank you for your feedback. On Mon, 2014-02-17 at 14:49 +0100, Johannes Berg wrote: > On Mon, 2014-02-17 at 14:22 +0100, Rostislav Lisovy wrote: > > Signed-off-by: Rostislav Lisovy <lisovy@xxxxxxxxx> > > Err, some text is definitely needed. > > > --- > > include/net/cfg80211.h | 19 ++++++- > > include/net/mac80211.h | 4 +- > > include/uapi/linux/nl80211.h | 17 ++++++- > > net/wireless/chan.c | 8 +++ > > net/wireless/core.c | 3 -- > > net/wireless/nl80211.c | 14 ++++++ > > net/wireless/reg.c | 115 ++++++++++++++++++++++++++++++++++++++----- > > 7 files changed, 161 insertions(+), 19 deletions(-) > > Umm. > > Might have mentioned that in your 0/4 that you want help on specific > things :) > > [I haven't even really reviewed the regulatory code] As you have already noticed, this is work in progress. I agree it is necessary to keep the code clean if I want others to read it -- I try to do so but it does not always go very well. One thing I am not sure about (mentioned in 0/4) and need some suggestions is frequency setting in the OCB mode. Since there are no beacons containing the information about the frequency to set, the frequency is set manually. Since the 'set_channel()' function is not present anymore (and we do not have 'ocb_join()' function, thus we cannot use 'preset_chandef'), I was not able to figure out how to set a fixed channel. If I would want to set the frequency with the ieee80211_vif_use_channel() function, I would need to somehow obtain the *sdata. If I check ieee80211_set_monitor_channel() I see how *sdata is obtained there, but I am not sure if it is a good idea to add *ocb_sdata to struct ieee80211_local? Best regards; Rostislav Lisovy -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
