On 13 February 2014 15:46, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote:
> Michal Kazior <michal.kazior@xxxxxxxxx> writes:
>
>> This allows dynamic changes of bandwidth/nss/smps,
>> e.g. via ht/vht operation mode change
>> notification.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx>
>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath10k/core.h
>> +++ b/drivers/net/wireless/ath/ath10k/core.h
>> @@ -228,6 +228,17 @@ struct ath10k_peer {
>> struct ieee80211_key_conf *keys[WMI_MAX_KEY_INDEX + 1];
>> };
>>
>> +struct ath10k_sta {
>> + struct ath10k_vif *arvif;
>> +
>> + u32 changed; /* IEEE80211_RC_* */
>> + u32 bw;
>> + u32 nss;
>> + u32 smps;
>> +
>> + struct work_struct update_wk;
>> +};
>
> Apparently this structure is protected with data_lock, but it would be
> good to document that in the code to make it clear.
Good point.
>> + case IEEE80211_STA_RX_BW_160:
>> + ath10k_warn("unsupported STA BW: %d\n", sta->bandwidth);
>> + bw = WMI_PEER_CHWIDTH_20MHZ;
>> + break;
>
> I think it would be also useful to print STA's address in the warning.
>
[...]
>> + case IEEE80211_SMPS_NUM_MODES:
>> + ath10k_warn("invalid smps mode: %d\n", sta->smps_mode);
>> + smps = WMI_PEER_SMPS_PS_NONE;
>> + break;
>
> Maybe here as well?
Sounds good. I'll send a v3 with all these things fixed.
Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
